summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYang Li <abaci-bugfix@linux.alibaba.com>2021-02-24 21:04:05 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2021-02-24 22:38:29 +0100
commit8a260162f9a0634db9a1ee7b8db276e7a00ee1d9 (patch)
tree31249ba44580e2712247f6f90f7e25d762d874eb
parentmm: page_counter: re-layout structure to reduce false sharing (diff)
downloadlinux-8a260162f9a0634db9a1ee7b8db276e7a00ee1d9.tar.xz
linux-8a260162f9a0634db9a1ee7b8db276e7a00ee1d9.zip
mm/memcontrol: remove redundant NULL check
Fix below warnings reported by coccicheck: mm/memcontrol.c:451:3-9: WARNING: NULL check before some freeing functions is not needed. Link: https://lkml.kernel.org/r/1611216029-34397-1-git-send-email-abaci-bugfix@linux.alibaba.com Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com> Reported-by: Abaci Robot <abaci@linux.alibaba.com> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: David Hildenbrand <david@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--mm/memcontrol.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index dce5291525a5..ed5cc78a8dbf 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -452,8 +452,7 @@ static void memcg_free_shrinker_maps(struct mem_cgroup *memcg)
for_each_node(nid) {
pn = mem_cgroup_nodeinfo(memcg, nid);
map = rcu_dereference_protected(pn->shrinker_map, true);
- if (map)
- kvfree(map);
+ kvfree(map);
rcu_assign_pointer(pn->shrinker_map, NULL);
}
}