diff options
| author | Sergey Shtylyov <s.shtylyov@omprussia.ru> | 2021-03-15 21:15:06 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2021-03-31 04:24:20 +0200 |
| commit | b30d0040f06159de97ad9c0b1536f47250719d7d (patch) | |
| tree | 9d61175d1fbab78bbe4484d958d161e918d13355 | |
| parent | sata_mv: add IRQ checks (diff) | |
| download | linux-b30d0040f06159de97ad9c0b1536f47250719d7d.tar.xz linux-b30d0040f06159de97ad9c0b1536f47250719d7d.zip | |
ata: libahci_platform: fix IRQ check
Iff platform_get_irq() returns 0, ahci_platform_init_host() would return 0
early (as if the call was successful). Override IRQ0 with -EINVAL instead
as the 'libata' regards 0 as "no IRQ" (thus polling) anyway...
Fixes: c034640a32f8 ("ata: libahci: properly propagate return value of platform_get_irq()")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Link: https://lore.kernel.org/r/4448c8cc-331f-2915-0e17-38ea34e251c8@omprussia.ru
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | drivers/ata/libahci_platform.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c index de638dafce21..b2f552088291 100644 --- a/drivers/ata/libahci_platform.c +++ b/drivers/ata/libahci_platform.c @@ -582,11 +582,13 @@ int ahci_platform_init_host(struct platform_device *pdev, int i, irq, n_ports, rc; irq = platform_get_irq(pdev, 0); - if (irq <= 0) { + if (irq < 0) { if (irq != -EPROBE_DEFER) dev_err(dev, "no irq\n"); return irq; } + if (!irq) + return -EINVAL; hpriv->irq = irq; |