diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2019-12-06 15:37:15 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2019-12-13 14:10:44 +0100 |
| commit | c7e54b5102bf3614cadb9ca32d7be73bad6cecf0 (patch) | |
| tree | 9a610b18e72bd0632b96371440b9b838df7fb768 | |
| parent | Btrfs: fix hole extent items with a zero size after range cloning (diff) | |
| download | linux-c7e54b5102bf3614cadb9ca32d7be73bad6cecf0.tar.xz linux-c7e54b5102bf3614cadb9ca32d7be73bad6cecf0.zip | |
btrfs: abort transaction after failed inode updates in create_subvol
We can just abort the transaction here, and in fact do that for every
other failure in this function except these two cases.
CC: stable@vger.kernel.org # 4.4+
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/ioctl.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 3418decb9e61..18e328ce4b54 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -704,11 +704,17 @@ static noinline int create_subvol(struct inode *dir, btrfs_i_size_write(BTRFS_I(dir), dir->i_size + namelen * 2); ret = btrfs_update_inode(trans, root, dir); - BUG_ON(ret); + if (ret) { + btrfs_abort_transaction(trans, ret); + goto fail; + } ret = btrfs_add_root_ref(trans, objectid, root->root_key.objectid, btrfs_ino(BTRFS_I(dir)), index, name, namelen); - BUG_ON(ret); + if (ret) { + btrfs_abort_transaction(trans, ret); + goto fail; + } ret = btrfs_uuid_tree_add(trans, root_item->uuid, BTRFS_UUID_KEY_SUBVOL, objectid); |