diff options
| author | Russell King (Oracle) <rmk+kernel@armlinux.org.uk> | 2021-10-28 16:55:34 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-10-29 14:29:30 +0200 |
| commit | fd8d9731bcdfb22d28e45bce789bcb211c868c78 (patch) | |
| tree | 193d96fdf4cc20c07b2db5ff90be5db28bf490a9 | |
| parent | Merge branch 'nfp-fixes' (diff) | |
| download | linux-fd8d9731bcdfb22d28e45bce789bcb211c868c78.tar.xz linux-fd8d9731bcdfb22d28e45bce789bcb211c868c78.zip | |
net: phylink: avoid mvneta warning when setting pause parameters
mvneta does not support asymetric pause modes, and it flags this by the
lack of AsymPause in the supported field. When setting pause modes, we
check that pause->rx_pause == pause->tx_pause, but only when pause
autoneg is enabled. When pause autoneg is disabled, we still allow
pause->rx_pause != pause->tx_pause, which is incorrect when the MAC
does not support asymetric pause, and causes mvneta to issue a warning.
Fix this by removing the test for pause->autoneg, so we always check
that pause->rx_pause == pause->tx_pause for network devices that do not
support AsymPause.
Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/phylink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 0a0abe8e4be0..5defc721dd05 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -1724,7 +1724,7 @@ int phylink_ethtool_set_pauseparam(struct phylink *pl, return -EOPNOTSUPP; if (!phylink_test(pl->supported, Asym_Pause) && - !pause->autoneg && pause->rx_pause != pause->tx_pause) + pause->rx_pause != pause->tx_pause) return -EINVAL; pause_state = 0; |