summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Renninger <trenn@suse.de>2007-05-21 14:20:04 +0200
committerDave Jones <davej@redhat.com>2007-05-29 22:56:40 +0200
commit0a4b2ccc555fa2ca6873d60219047104e4805d45 (patch)
tree3641776d5ad881047b5fa3ff64f55ab427c85a40
parent[CPUFREQ] Longhaul - Check ACPI "BM DMA in progress" bit (diff)
downloadlinux-0a4b2ccc555fa2ca6873d60219047104e4805d45.tar.xz
linux-0a4b2ccc555fa2ca6873d60219047104e4805d45.zip
[CPUFREQ] check return value of sysfs_create_file
Eliminate build warning (sysfs_create_file return value must be checked) Signed-off-by: Thomas Renninger <trenn@suse.de> Signed-off-by: Dave Jones <davej@redhat.com>
-rw-r--r--drivers/cpufreq/cpufreq.c15
1 files changed, 10 insertions, 5 deletions
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index eb37fba9b7ef..0521427a571e 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -826,13 +826,18 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
/* set up files for this cpu device */
drv_attr = cpufreq_driver->attr;
while ((drv_attr) && (*drv_attr)) {
- sysfs_create_file(&policy->kobj, &((*drv_attr)->attr));
+ if (sysfs_create_file(&policy->kobj, &((*drv_attr)->attr)))
+ goto err_out_driver_exit;
drv_attr++;
}
- if (cpufreq_driver->get)
- sysfs_create_file(&policy->kobj, &cpuinfo_cur_freq.attr);
- if (cpufreq_driver->target)
- sysfs_create_file(&policy->kobj, &scaling_cur_freq.attr);
+ if (cpufreq_driver->get){
+ if (sysfs_create_file(&policy->kobj, &cpuinfo_cur_freq.attr))
+ goto err_out_driver_exit;
+ }
+ if (cpufreq_driver->target){
+ if (sysfs_create_file(&policy->kobj, &scaling_cur_freq.attr))
+ goto err_out_driver_exit;
+ }
spin_lock_irqsave(&cpufreq_driver_lock, flags);
for_each_cpu_mask(j, policy->cpus) {