summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Kicinski <jakub.kicinski@netronome.com>2016-06-06 17:16:47 +0200
committerDavid S. Miller <davem@davemloft.net>2016-06-08 01:27:14 +0200
commit1a0f7d2984f3864e64a43714b4a0999b5a27cff5 (patch)
tree0f7acc82153b28cbc827d6c72c1be184dc2b76a1
parentgtp: #define _UAPI_LINUX_GTP_H_ and not _UAPI_LINUX_GTP_H__ (diff)
downloadlinux-1a0f7d2984f3864e64a43714b4a0999b5a27cff5.tar.xz
linux-1a0f7d2984f3864e64a43714b4a0999b5a27cff5.zip
net: cls_u32: fix error code for invalid flags
'err' variable is not set in this test, we would return whatever previous test set 'err' to. Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Acked-by: Sridhar Samudrala <sridhar.samudrala@intel.com> Acked-by: John Fastabend <john.r.fastabend@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/sched/cls_u32.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index 079b43b3c5d2..b17e090f2fe1 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -863,7 +863,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
if (tb[TCA_U32_FLAGS]) {
flags = nla_get_u32(tb[TCA_U32_FLAGS]);
if (!tc_flags_valid(flags))
- return err;
+ return -EINVAL;
}
n = (struct tc_u_knode *)*arg;