diff options
| author | Marek Szyprowski <m.szyprowski@samsung.com> | 2011-06-08 11:15:05 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-07-01 03:32:28 +0200 |
| commit | bf7b73efb7f52abf56b512546c3bbc35001dd696 (patch) | |
| tree | a24f0100160273770911025e7fd458fd02602288 | |
| parent | [media] media: vb2: add __GFP_NOWARN to dma-sg allocator (diff) | |
| download | linux-bf7b73efb7f52abf56b512546c3bbc35001dd696.tar.xz linux-bf7b73efb7f52abf56b512546c3bbc35001dd696.zip | |
[media] Revert "[media] v4l2: vb2: one more fix for REQBUFS()"
This reverts commit 31901a078af29c33c736dcbf815656920e904632.
Queue should be reinitialized on each REQBUFS() call even if the memory
access method and buffer count have not been changed. The user might have
changed the format and if we go the short path introduced in that commit,
the memory buffer will not be reallocated to fit with new format.
The previous patch was just over-engineered optimization, which just
introduced a bug to videobuf2.
Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
CC: Pawel Osciak <pawel@osciak.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| -rw-r--r-- | drivers/media/video/videobuf2-core.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video/videobuf2-core.c index 6ba1461d51ef..6489aa26e788 100644 --- a/drivers/media/video/videobuf2-core.c +++ b/drivers/media/video/videobuf2-core.c @@ -492,13 +492,6 @@ int vb2_reqbufs(struct vb2_queue *q, struct v4l2_requestbuffers *req) return -EINVAL; } - /* - * If the same number of buffers and memory access method is requested - * then return immediately. - */ - if (q->memory == req->memory && req->count == q->num_buffers) - return 0; - if (req->count == 0 || q->num_buffers != 0 || q->memory != req->memory) { /* * We already have buffers allocated, so first check if they |