diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-10-28 08:04:47 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-10-30 00:42:17 +0100 |
| commit | 76d7774e203d422edb6b8c6db800478ca029fde5 (patch) | |
| tree | 24b2f66b693550521d9f5d9cc2bed5fafd5f765c | |
| parent | net: aquantia: remove unused including <linux/version.h> (diff) | |
| download | linux-76d7774e203d422edb6b8c6db800478ca029fde5.tar.xz linux-76d7774e203d422edb6b8c6db800478ca029fde5.zip | |
net: aquantia: fix error handling in aq_ptp_poll
Fix currenty ignored returned error by properly checking *err* after
calling aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill().
Addresses-Coverity-ID: 1487357 ("Unused value")
Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/aquantia/atlantic/aq_ptp.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c index 4ca36003c6ca..8175513e48c9 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c @@ -678,6 +678,8 @@ static int aq_ptp_poll(struct napi_struct *napi, int budget) err = aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill(aq_nic->aq_hw, &aq_ptp->hwts_rx); + if (err < 0) + goto err_exit; was_cleaned = true; } |