diff options
| author | Emmanuel Grumbach <emmanuel.grumbach@intel.com> | 2022-10-30 18:17:43 +0100 |
|---|---|---|
| committer | Gregory Greenman <gregory.greenman@intel.com> | 2022-11-10 12:26:16 +0100 |
| commit | bcd68b3dbe78b7b0f7b6b55162cf1eff1e7fff9e (patch) | |
| tree | 09084045a4dd73bb64d0443eb6e3d4a94e43a349 | |
| parent | wifi: iwlwifi: mei: don't send SAP commands if AMT is disabled (diff) | |
| download | linux-bcd68b3dbe78b7b0f7b6b55162cf1eff1e7fff9e.tar.xz linux-bcd68b3dbe78b7b0f7b6b55162cf1eff1e7fff9e.zip | |
wifi: iwlwifi: mei: fix tx DHCP packet for devices with new Tx API
Devices with new Tx API have the IV introduced by the HW and it is not
present in the skb at all. Hence we don't need to tell
iwl_mvm_mei_tx_copy_to_csme to jump over 8 bytes to get to the ethernet
header.
Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20221030191011.12dc42133502.Idd744ffeeb84b880eb497963ee02563cbb959a42@changeid
| -rw-r--r-- | drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c index 86d20e13bf47..ba335f57771c 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c @@ -1171,9 +1171,15 @@ static int iwl_mvm_tx_mpdu(struct iwl_mvm *mvm, struct sk_buff *skb, /* From now on, we cannot access info->control */ iwl_mvm_skb_prepare_status(skb, dev_cmd); + /* + * The IV is introduced by the HW for new tx api, and it is not present + * in the skb, hence, don't tell iwl_mvm_mei_tx_copy_to_csme about the + * IV for those devices. + */ if (ieee80211_is_data(fc)) iwl_mvm_mei_tx_copy_to_csme(mvm, skb, - info->control.hw_key ? + info->control.hw_key && + !iwl_mvm_has_new_tx_api(mvm) ? info->control.hw_key->iv_len : 0); if (iwl_trans_tx(mvm->trans, skb, dev_cmd, txq_id)) |