diff options
| author | Jan Kara <jack@suse.cz> | 2009-04-27 16:43:49 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-12 03:36:03 +0200 |
| commit | bfe881255c74800147523b59c85328a1a826ba21 (patch) | |
| tree | 4ed9b761a440ee0b69a35a5c8bddc42c64195e47 | |
| parent | vfs: Fix sys_sync() and fsync_super() reliability (version 4) (diff) | |
| download | linux-bfe881255c74800147523b59c85328a1a826ba21.tar.xz linux-bfe881255c74800147523b59c85328a1a826ba21.zip | |
vfs: Call ->sync_fs() even if s_dirt is 0 (version 4)
sync_filesystems() has a condition that if wait == 0 and s_dirt == 0, then
->sync_fs() isn't called. This does not really make much sence since s_dirt is
generally used by a filesystem to mean that ->write_super() needs to be called.
But ->sync_fs() does different things. I even suspect that some filesystems
(btrfs?) sets s_dirt just to fool this logic.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| -rw-r--r-- | fs/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/super.c b/fs/super.c index 18d159dc1e40..fae91ba38e48 100644 --- a/fs/super.c +++ b/fs/super.c @@ -510,7 +510,7 @@ restart: sb->s_count++; spin_unlock(&sb_lock); down_read(&sb->s_umount); - if (sb->s_root && (wait || sb->s_dirt)) + if (sb->s_root) sb->s_op->sync_fs(sb, wait); up_read(&sb->s_umount); /* restart only when sb is no longer on the list */ |