diff options
| author | Wenlin Kang <wenlin.kang@windriver.com> | 2019-05-13 10:57:20 +0200 |
|---|---|---|
| committer | Daniel Thompson <daniel.thompson@linaro.org> | 2019-05-14 14:44:24 +0200 |
| commit | ca976bfb3154c7bc67c4651ecd144fdf67ccaee7 (patch) | |
| tree | c14984408a43c210a00b4a24334a52f36462fccc | |
| parent | kdb: do a sanity check on the cpu in kdb_per_cpu() (diff) | |
| download | linux-ca976bfb3154c7bc67c4651ecd144fdf67ccaee7.tar.xz linux-ca976bfb3154c7bc67c4651ecd144fdf67ccaee7.zip | |
kdb: Fix bound check compiler warning
The strncpy() function may leave the destination string buffer
unterminated, better use strscpy() instead.
This fixes the following warning with gcc 8.2:
kernel/debug/kdb/kdb_io.c: In function 'kdb_getstr':
kernel/debug/kdb/kdb_io.c:449:3: warning: 'strncpy' specified bound 256 equals destination size [-Wstringop-truncation]
strncpy(kdb_prompt_str, prompt, CMD_BUFLEN);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Wenlin Kang <wenlin.kang@windriver.com>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
| -rw-r--r-- | kernel/debug/kdb/kdb_io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index 6a4b41484afe..3a5184eb6977 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c @@ -446,7 +446,7 @@ poll_again: char *kdb_getstr(char *buffer, size_t bufsize, const char *prompt) { if (prompt && kdb_prompt_str != prompt) - strncpy(kdb_prompt_str, prompt, CMD_BUFLEN); + strscpy(kdb_prompt_str, prompt, CMD_BUFLEN); kdb_printf(kdb_prompt_str); kdb_nextline = 1; /* Prompt and input resets line number */ return kdb_read(buffer, bufsize); |