diff options
| author | Paulo Alcantara <pc@manguebit.com> | 2023-03-29 22:14:22 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-03-31 00:56:27 +0200 |
| commit | 09ba47b44d26b475bbdf9c80db9e0193d2b58956 (patch) | |
| tree | 68e5a933cced5c5903f5ea827c81e6aff1af2d9e | |
| parent | cifs: avoid races in parallel reconnects in smb1 (diff) | |
| download | linux-09ba47b44d26b475bbdf9c80db9e0193d2b58956.tar.xz linux-09ba47b44d26b475bbdf9c80db9e0193d2b58956.zip | |
cifs: prevent infinite recursion in CIFSGetDFSRefer()
We can't call smb_init() in CIFSGetDFSRefer() as cifs_reconnect_tcon()
may end up calling CIFSGetDFSRefer() again to get new DFS referrals
and thus causing an infinite recursion.
Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Cc: stable@vger.kernel.org # 6.2
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/cifs/cifssmb.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index c9d57ba84be4..0d30b17494e4 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -4382,8 +4382,13 @@ CIFSGetDFSRefer(const unsigned int xid, struct cifs_ses *ses, return -ENODEV; getDFSRetry: - rc = smb_init(SMB_COM_TRANSACTION2, 15, ses->tcon_ipc, (void **) &pSMB, - (void **) &pSMBr); + /* + * Use smb_init_no_reconnect() instead of smb_init() as + * CIFSGetDFSRefer() may be called from cifs_reconnect_tcon() and thus + * causing an infinite recursion. + */ + rc = smb_init_no_reconnect(SMB_COM_TRANSACTION2, 15, ses->tcon_ipc, + (void **)&pSMB, (void **)&pSMBr); if (rc) return rc; |