diff options
| author | Markus Rechberger <markus.rechberger@amd.com> | 2007-08-13 19:20:43 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-10-12 23:51:06 +0200 |
| commit | 109f0e93b6b728f03c1eb4af02bc25d71b646c59 (patch) | |
| tree | 3976e39808f95760a0ef3d022c59e358bacc8213 | |
| parent | Driver core: kerneldoc - kobject_uevent_env is not "usually KOBJ_MOVE" (diff) | |
| download | linux-109f0e93b6b728f03c1eb4af02bc25d71b646c59.tar.xz linux-109f0e93b6b728f03c1eb4af02bc25d71b646c59.zip | |
Fix Firmware class name collision
following patch fixes the i2c name collision with i2c-dev.
http://mcentral.de/wiki/index.php/Bugtracker#i2c_core_problem
This issue has been experienced with em28xx and saa7133 based devices.
I discussed that problem with Jean Delvare a while ago and he proposed
to add a prefix to the class name.
Signed-off-by: Markus Rechberger <markus.rechberger@amd.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/base/firmware_class.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 4a1b9bfc5471..0295855a3eef 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -292,8 +292,7 @@ firmware_class_timeout(u_long data) static inline void fw_setup_device_id(struct device *f_dev, struct device *dev) { - /* XXX warning we should watch out for name collisions */ - strlcpy(f_dev->bus_id, dev->bus_id, BUS_ID_SIZE); + snprintf(f_dev->bus_id, BUS_ID_SIZE, "firmware-%s", dev->bus_id); } static int fw_register_device(struct device **dev_p, const char *fw_name, |