summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2017-03-06 17:36:38 +0100
committerJohan Hovold <johan@kernel.org>2017-03-08 16:14:36 +0100
commit30572418b445d85fcfe6c8fe84c947d2606767d8 (patch)
treea5fb8b9ea93267ad43dfd8431fa6621e397d056d
parentUSB: serial: io_ti: fix NULL-deref in interrupt callback (diff)
downloadlinux-30572418b445d85fcfe6c8fe84c947d2606767d8.tar.xz
linux-30572418b445d85fcfe6c8fe84c947d2606767d8.zip
USB: serial: omninet: fix reference leaks at open
This driver needlessly took another reference to the tty on open, a reference which was then never released on close. This lead to not just a leak of the tty, but also a driver reference leak that prevented the driver from being unloaded after a port had once been opened. Fixes: 4a90f09b20f4 ("tty: usb-serial krefs") Cc: stable <stable@vger.kernel.org> # 2.6.28 Signed-off-by: Johan Hovold <johan@kernel.org>
-rw-r--r--drivers/usb/serial/omninet.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
index a180b17d2432..76564b3bebb9 100644
--- a/drivers/usb/serial/omninet.c
+++ b/drivers/usb/serial/omninet.c
@@ -142,12 +142,6 @@ static int omninet_port_remove(struct usb_serial_port *port)
static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port)
{
- struct usb_serial *serial = port->serial;
- struct usb_serial_port *wport;
-
- wport = serial->port[1];
- tty_port_tty_set(&wport->port, tty);
-
return usb_serial_generic_open(tty, port);
}