diff options
| author | Ilya Leoshkevich <iii@linux.ibm.com> | 2019-08-30 13:07:30 +0200 |
|---|---|---|
| committer | Daniel Borkmann <daniel@iogearbox.net> | 2019-09-03 21:01:52 +0200 |
| commit | 3404ddf234ba4677bf224cb15ddcdea0ceab956e (patch) | |
| tree | 7dde5f4430846f68a01a48440d0e63f9ae56fa3f | |
| parent | selftests/bpf: introduce bpf_cpu_to_be64 and bpf_be64_to_cpu (diff) | |
| download | linux-3404ddf234ba4677bf224cb15ddcdea0ceab956e.tar.xz linux-3404ddf234ba4677bf224cb15ddcdea0ceab956e.zip | |
selftests/bpf: fix "ctx:write sysctl:write read ok" on s390
"ctx:write sysctl:write read ok" fails on s390 because it reads the
first byte of an int assuming it's the least-significant one, which
is not the case on big-endian arches. Since we are not testing narrow
accesses here (there is e.g. "ctx:file_pos sysctl:read read ok narrow"
for that), simply read the whole int.
Fixes: 1f5fa9ab6e2e ("selftests/bpf: Test BPF_CGROUP_SYSCTL")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
| -rw-r--r-- | tools/testing/selftests/bpf/test_sysctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/test_sysctl.c b/tools/testing/selftests/bpf/test_sysctl.c index a3bebd7c68dd..908f327839d5 100644 --- a/tools/testing/selftests/bpf/test_sysctl.c +++ b/tools/testing/selftests/bpf/test_sysctl.c @@ -100,7 +100,7 @@ static struct sysctl_test tests[] = { .descr = "ctx:write sysctl:write read ok", .insns = { /* If (write) */ - BPF_LDX_MEM(BPF_B, BPF_REG_7, BPF_REG_1, + BPF_LDX_MEM(BPF_W, BPF_REG_7, BPF_REG_1, offsetof(struct bpf_sysctl, write)), BPF_JMP_IMM(BPF_JNE, BPF_REG_7, 1, 2), |