diff options
| author | Rouven Czerwinski <r.czerwinski@pengutronix.de> | 2021-06-16 14:53:31 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-06-16 16:41:20 +0200 |
| commit | 7740ab84c13e32002742106afd443a4ca7fe3918 (patch) | |
| tree | 2f1d0ebe65439a5b200c51d0e0b3a0aa0b8d7b73 | |
| parent | regulator: sy7636a: Use rdev_get_drvdata at proper place (diff) | |
| download | linux-7740ab84c13e32002742106afd443a4ca7fe3918.tar.xz linux-7740ab84c13e32002742106afd443a4ca7fe3918.zip | |
regulator: fixed: use dev_err_probe for gpio
Instead of returning the the PTR_ERR directly, use dev_err_probe which
will also correctly set the deferred probe reason in
/sys/kernel/debug/deferred_devices, making it easier to debug missing
devices on the system.
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Link: https://lore.kernel.org/r/20210616125331.153414-1-r.czerwinski@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/fixed.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index 02ad83153e19..78f3a938b39b 100644 --- a/drivers/regulator/fixed.c +++ b/drivers/regulator/fixed.c @@ -271,7 +271,8 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev) */ cfg.ena_gpiod = gpiod_get_optional(&pdev->dev, NULL, gflags); if (IS_ERR(cfg.ena_gpiod)) - return PTR_ERR(cfg.ena_gpiod); + return dev_err_probe(&pdev->dev, PTR_ERR(cfg.ena_gpiod), + "can't get GPIO\n"); cfg.dev = &pdev->dev; cfg.init_data = config->init_data; |