summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSebin Sebastian <mailmesebin00@gmail.com>2022-08-01 06:07:31 +0200
committerJakub Kicinski <kuba@kernel.org>2022-08-02 05:32:07 +0200
commit969e26c63d309c3555905f894560bcdee42f3464 (patch)
tree0bf9ac02219daa2763f20cd8744e2469472774b4
parentnet: devlink: Fix missing mutex_unlock() call (diff)
downloadlinux-969e26c63d309c3555905f894560bcdee42f3464.tar.xz
linux-969e26c63d309c3555905f894560bcdee42f3464.zip
net: marvell: prestera: remove reduntant code
Fixes the coverity warning 'EVALUATION_ORDER' violation. port is written twice with the same value. Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com> Link: https://lore.kernel.org/r/20220801040731.34741-1-mailmesebin00@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--drivers/net/ethernet/marvell/prestera/prestera_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 4b64bda3f9c2..ede3e53b9790 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -290,7 +290,7 @@ static int prestera_pcs_config(struct phylink_pcs *pcs,
const unsigned long *advertising,
bool permit_pause_to_mac)
{
- struct prestera_port *port = port = prestera_pcs_to_port(pcs);
+ struct prestera_port *port = prestera_pcs_to_port(pcs);
struct prestera_port_mac_config cfg_mac;
int err;