summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLuis Chamberlain <mcgrof@kernel.org>2023-03-19 22:27:40 +0100
committerLuis Chamberlain <mcgrof@kernel.org>2023-03-24 19:33:08 +0100
commitad8d3a36e981064f8a646531cddca30516894457 (patch)
tree1ba2306797c0f0eb7cc0fdc5bbb29ca24b2a83a8
parentmodule: move check_modinfo() early to early_mod_check() (diff)
downloadlinux-ad8d3a36e981064f8a646531cddca30516894457.tar.xz
linux-ad8d3a36e981064f8a646531cddca30516894457.zip
module: rename set_license() to module_license_taint_check()
The set_license() routine would seem to a reader to do some sort of setting, but it does not. It just adds a taint if the license is not set or proprietary. This makes what the code is doing clearer, so much we can remove the comment about it. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
-rw-r--r--kernel/module/main.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/kernel/module/main.c b/kernel/module/main.c
index 95fd705328ac..5e64485ac05a 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -1573,7 +1573,7 @@ static void layout_sections(struct module *mod, struct load_info *info)
__layout_sections(mod, info, true);
}
-static void set_license(struct module *mod, const char *license)
+static void module_license_taint_check(struct module *mod, const char *license)
{
if (!license)
license = "unspecified";
@@ -1993,8 +1993,7 @@ static int check_modinfo(struct module *mod, struct load_info *info, int flags)
if (err)
return err;
- /* Set up license info based on the info section */
- set_license(mod, get_modinfo(info, "license"));
+ module_license_taint_check(mod, get_modinfo(info, "license"));
if (get_modinfo(info, "test")) {
if (!test_taint(TAINT_TEST))