summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@suse.de>2010-11-15 20:17:52 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2010-11-15 23:04:14 +0100
commitd9624e75f6ad94d8a0718c1fafa89186d271a78c (patch)
treeb7178df164f6ee8e7c4640e5b458b8776c9640f9
parentUSB: ehci: fix debugfs 'lpm' permissions (diff)
downloadlinux-d9624e75f6ad94d8a0718c1fafa89186d271a78c.tar.xz
linux-d9624e75f6ad94d8a0718c1fafa89186d271a78c.zip
USB: storage: sierra_ms: fix sysfs file attribute
A non-writable sysfs file shouldn't have writable attributes. Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: Kevin Lloyd <klloyd@sierrawireless.com> Cc: Matthew Dharm <mdharm-usb@one-eyed-alien.net> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/storage/sierra_ms.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/storage/sierra_ms.c b/drivers/usb/storage/sierra_ms.c
index 57fc2f532cab..ceba512f84d0 100644
--- a/drivers/usb/storage/sierra_ms.c
+++ b/drivers/usb/storage/sierra_ms.c
@@ -121,7 +121,7 @@ static ssize_t show_truinst(struct device *dev, struct device_attribute *attr,
}
return result;
}
-static DEVICE_ATTR(truinst, S_IWUGO | S_IRUGO, show_truinst, NULL);
+static DEVICE_ATTR(truinst, S_IRUGO, show_truinst, NULL);
int sierra_ms_init(struct us_data *us)
{