diff options
| author | Konstantin Komarov <almaz.alexandrovich@paragon-software.com> | 2021-09-08 17:39:53 +0200 |
|---|---|---|
| committer | Konstantin Komarov <almaz.alexandrovich@paragon-software.com> | 2021-09-21 17:36:40 +0200 |
| commit | ee9d4810aab95208541d2807f9d114f1d5edcee0 (patch) | |
| tree | 26a3bf3fa2d2d3e5ecdf9f8c4c9c3a9f8660d1e9 | |
| parent | fs/ntfs3: Fix a memory leak on object opts (diff) | |
| download | linux-ee9d4810aab95208541d2807f9d114f1d5edcee0.tar.xz linux-ee9d4810aab95208541d2807f9d114f1d5edcee0.zip | |
fs/ntfs3: Fix insertion of attr in ni_ins_attr_ext
Do not try to insert attribute if there is no room in record.
Reviewed-by: Kari Argillander <kari.argillander@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
| -rw-r--r-- | fs/ntfs3/frecord.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c index 1e1a09034f65..0d00b2301a2f 100644 --- a/fs/ntfs3/frecord.c +++ b/fs/ntfs3/frecord.c @@ -953,6 +953,13 @@ static int ni_ins_attr_ext(struct ntfs_inode *ni, struct ATTR_LIST_ENTRY *le, continue; } + /* + * Do not try to insert this attribute + * if there is no room in record. + */ + if (le32_to_cpu(mi->mrec->used) + asize > sbi->record_size) + continue; + /* Try to insert attribute into this subrecord. */ attr = ni_ins_new_attr(ni, mi, le, type, name, name_len, asize, name_off, svcn, ins_le); |