diff options
| author | William Breathitt Gray <william.gray@linaro.org> | 2023-03-16 21:34:26 +0100 |
|---|---|---|
| committer | William Breathitt Gray <william.gray@linaro.org> | 2023-03-18 14:26:40 +0100 |
| commit | 00f4bc5184c19cb33f468f1ea409d70d19f8f502 (patch) | |
| tree | dc0110912389835d3f4e1c84883badfa57316d65 | |
| parent | counter: 104-quad-8: Fix race condition between FLAG and CNTR reads (diff) | |
| download | linux-00f4bc5184c19cb33f468f1ea409d70d19f8f502.tar.xz linux-00f4bc5184c19cb33f468f1ea409d70d19f8f502.zip | |
counter: 104-quad-8: Fix Synapse action reported for Index signals
Signal 16 and higher represent the device's Index lines. The
priv->preset_enable array holds the device configuration for these Index
lines. The preset_enable configuration is active low on the device, so
invert the conditional check in quad8_action_read() to properly handle
the logical state of preset_enable.
Fixes: f1d8a071d45b ("counter: 104-quad-8: Add Generic Counter interface support")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230316203426.224745-1-william.gray@linaro.org/
Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
| -rw-r--r-- | drivers/counter/104-quad-8.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c index d59e4f34a680..d9cb937665cf 100644 --- a/drivers/counter/104-quad-8.c +++ b/drivers/counter/104-quad-8.c @@ -368,7 +368,7 @@ static int quad8_action_read(struct counter_device *counter, /* Handle Index signals */ if (synapse->signal->id >= 16) { - if (priv->preset_enable[count->id]) + if (!priv->preset_enable[count->id]) *action = COUNTER_SYNAPSE_ACTION_RISING_EDGE; else *action = COUNTER_SYNAPSE_ACTION_NONE; |