diff options
| author | Lyude Paul <lyude@redhat.com> | 2020-08-26 20:24:47 +0200 |
|---|---|---|
| committer | Lyude Paul <lyude@redhat.com> | 2020-09-01 01:10:08 +0200 |
| commit | 02bb7fe2d3eacb5ca1cec597ad16eff93ae8d769 (patch) | |
| tree | bf8ad358db2d3da4db64c9ec47806f2bce69b5b3 | |
| parent | drm/nouveau/kms: Use new drm_dp_read_mst_cap() helper for checking MST caps (diff) | |
| download | linux-02bb7fe2d3eacb5ca1cec597ad16eff93ae8d769.tar.xz linux-02bb7fe2d3eacb5ca1cec597ad16eff93ae8d769.zip | |
drm/nouveau/kms: Move drm_dp_cec_unset_edid() into nouveau_connector_detect()
For whatever reason we currently unset the EDID for DP CEC support when
responding to the connector being unplugged, instead of just doing it in
nouveau_connector_detect() where we set the CEC EDID. This isn't really
needed and could even potentially cause us to forget to unset the EDID
if the connector is removed without a corresponding hpd event, so let's
fix that.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200826182456.322681-12-lyude@redhat.com
| -rw-r--r-- | drivers/gpu/drm/nouveau/nouveau_connector.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index b90591114faa..4a29f691c08e 100644 --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -633,10 +633,11 @@ detect_analog: conn_status = connector_status_connected; goto out; } - } out: + if (!nv_connector->edid) + drm_dp_cec_unset_edid(&nv_connector->aux); pm_runtime_mark_last_busy(dev->dev); pm_runtime_put_autosuspend(dev->dev); @@ -1174,8 +1175,6 @@ nouveau_connector_hotplug(struct nvif_notify *notify) return NVIF_NOTIFY_DROP; } - if (!plugged) - drm_dp_cec_unset_edid(&nv_connector->aux); NV_DEBUG(drm, "%splugged %s\n", plugged ? "" : "un", name); drm_helper_hpd_irq_event(connector->dev); |