summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-10-26 02:25:36 +0200
committerDavid S. Miller <davem@davemloft.net>2010-10-27 21:23:20 +0200
commit13c3ab86f27967488b8182a173ebc899c9111bf0 (patch)
tree1bcfa9b90c9226fc04d12d5863c829858dd9466f
parentdrivers/net/sb1000.c: delete double assignment (diff)
downloadlinux-13c3ab86f27967488b8182a173ebc899c9111bf0.tar.xz
linux-13c3ab86f27967488b8182a173ebc899c9111bf0.zip
drivers/net/typhoon.c: delete double assignment
Delete successive assignments to the same location. The current definition does not initialize the respRing structure, which has the same type as the cmdRing structure, so initialize that one instead. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression i; @@ *i = ...; i = ...; // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: David Dillow <dave@thedillows.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/typhoon.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
index b550da008a03..5b83c3f35f47 100644
--- a/drivers/net/typhoon.c
+++ b/drivers/net/typhoon.c
@@ -1300,7 +1300,7 @@ typhoon_init_rings(struct typhoon *tp)
tp->rxHiRing.lastWrite = 0;
tp->rxBuffRing.lastWrite = 0;
tp->cmdRing.lastWrite = 0;
- tp->cmdRing.lastWrite = 0;
+ tp->respRing.lastWrite = 0;
tp->txLoRing.lastRead = 0;
tp->txHiRing.lastRead = 0;