diff options
| author | Ben Hutchings <ben.hutchings@codethink.co.uk> | 2018-01-22 21:11:06 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-01-23 05:13:07 +0100 |
| commit | 1995266727fa8143897e89b55f5d3c79aa828420 (patch) | |
| tree | 2955860ce332561b8021ac8f07141e8a6849ad62 | |
| parent | orangefs: initialize op on loop restart in orangefs_devreq_read (diff) | |
| download | linux-1995266727fa8143897e89b55f5d3c79aa828420.tar.xz linux-1995266727fa8143897e89b55f5d3c79aa828420.zip | |
nfsd: auth: Fix gid sorting when rootsquash enabled
Commit bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility
group_info allocators") appears to break nfsd rootsquash in a pretty
major way.
It adds a call to groups_sort() inside the loop that copies/squashes
gids, which means the valid gids are sorted along with the following
garbage. The net result is that the highest numbered valid gids are
replaced with any lower-valued garbage gids, possibly including 0.
We should sort only once, after filling in all the gids.
Fixes: bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility ...")
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Acked-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/nfsd/auth.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/nfsd/auth.c b/fs/nfsd/auth.c index f650e475d8f0..fdf2aad73470 100644 --- a/fs/nfsd/auth.c +++ b/fs/nfsd/auth.c @@ -60,10 +60,10 @@ int nfsd_setuser(struct svc_rqst *rqstp, struct svc_export *exp) gi->gid[i] = exp->ex_anon_gid; else gi->gid[i] = rqgi->gid[i]; - - /* Each thread allocates its own gi, no race */ - groups_sort(gi); } + + /* Each thread allocates its own gi, no race */ + groups_sort(gi); } else { gi = get_group_info(rqgi); } |