summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorzhang songyi <zhang.songyi@zte.com.cn>2022-12-02 03:42:04 +0100
committerArnd Bergmann <arnd@arndb.de>2022-12-04 13:10:57 +0100
commit1d9ae5a1356a61cef94b34e4ccb28986955e2fd2 (patch)
tree3c99bf77546462786567d81534df7093e6e66be5
parentMerge tag 'arm-soc/for-6.2/drivers' of https://github.com/Broadcom/stblinux i... (diff)
downloadlinux-1d9ae5a1356a61cef94b34e4ccb28986955e2fd2.tar.xz
linux-1d9ae5a1356a61cef94b34e4ccb28986955e2fd2.zip
pxa: Remove dev_err() after platform_get_irq()
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn> Reviewed-by: Lubomir Rintel <lkundrak@v3.sk> Link: https://lore.kernel.org/r/202212021042043546303@zte.com.cn Signed-off-by: Arnd Bergmann <arnd@arndb.de>
-rw-r--r--drivers/soc/pxa/ssp.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c
index 93449fb3519e..bd029e838241 100644
--- a/drivers/soc/pxa/ssp.c
+++ b/drivers/soc/pxa/ssp.c
@@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev)
}
ssp->irq = platform_get_irq(pdev, 0);
- if (ssp->irq < 0) {
- dev_err(dev, "no IRQ resource defined\n");
+ if (ssp->irq < 0)
return -ENODEV;
- }
if (dev->of_node) {
const struct of_device_id *id =