diff options
| author | r.hering@avm.de <r.hering@avm.de> | 2018-01-12 15:42:06 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-01-15 20:21:57 +0100 |
| commit | 30be8f8dba1bd2aff73e8447d59228471233a3d4 (patch) | |
| tree | 752832ec446e7514fc64428f06a65fe2a2c28012 | |
| parent | ipv6: ip6_make_skb() needs to clear cork.base.dst (diff) | |
| download | linux-30be8f8dba1bd2aff73e8447d59228471233a3d4.tar.xz linux-30be8f8dba1bd2aff73e8447d59228471233a3d4.zip | |
net/tls: Fix inverted error codes to avoid endless loop
sendfile() calls can hang endless with using Kernel TLS if a socket error occurs.
Socket error codes must be inverted by Kernel TLS before returning because
they are stored with positive sign. If returned non-inverted they are
interpreted as number of bytes sent, causing endless looping of the
splice mechanic behind sendfile().
Signed-off-by: Robert Hering <r.hering@avm.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | include/net/tls.h | 2 | ||||
| -rw-r--r-- | net/tls/tls_sw.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/include/net/tls.h b/include/net/tls.h index 936cfc5cab7d..9185e53a743c 100644 --- a/include/net/tls.h +++ b/include/net/tls.h @@ -170,7 +170,7 @@ static inline bool tls_is_pending_open_record(struct tls_context *tls_ctx) static inline void tls_err_abort(struct sock *sk) { - sk->sk_err = -EBADMSG; + sk->sk_err = EBADMSG; sk->sk_error_report(sk); } diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index 73d19210dd49..9773571b6a34 100644 --- a/net/tls/tls_sw.c +++ b/net/tls/tls_sw.c @@ -391,7 +391,7 @@ int tls_sw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) while (msg_data_left(msg)) { if (sk->sk_err) { - ret = sk->sk_err; + ret = -sk->sk_err; goto send_end; } @@ -544,7 +544,7 @@ int tls_sw_sendpage(struct sock *sk, struct page *page, size_t copy, required_size; if (sk->sk_err) { - ret = sk->sk_err; + ret = -sk->sk_err; goto sendpage_end; } |