diff options
| author | Juergen Gross <jgross@suse.com> | 2019-10-18 09:45:49 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-10-19 20:43:29 +0200 |
| commit | 3d5c1a037d37392a6859afbde49be5ba6a70a6b3 (patch) | |
| tree | 04bcb32899722e30dab4be6a65cd6ed1e6430909 | |
| parent | net: hns3: fix mis-counting IRQ vector numbers issue (diff) | |
| download | linux-3d5c1a037d37392a6859afbde49be5ba6a70a6b3.tar.xz linux-3d5c1a037d37392a6859afbde49be5ba6a70a6b3.zip | |
xen/netback: fix error path of xenvif_connect_data()
xenvif_connect_data() calls module_put() in case of error. This is
wrong as there is no related module_get().
Remove the superfluous module_put().
Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")
Cc: <stable@vger.kernel.org> # 3.12
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/xen-netback/interface.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index 240f762b3749..103ed00775eb 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -719,7 +719,6 @@ err_unmap: xenvif_unmap_frontend_data_rings(queue); netif_napi_del(&queue->napi); err: - module_put(THIS_MODULE); return err; } |