summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Sesterhenn <snakebyte@gmx.de>2006-08-22 00:31:05 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2006-09-27 20:58:55 +0200
commit55359021b9a75a6d61a49ca8b9a1209793cd55f7 (patch)
tree6629b914a76f169184e52bc08d9ef0a0316f1d33
parentUSB core: Use const where possible. (diff)
downloadlinux-55359021b9a75a6d61a49ca8b9a1209793cd55f7.tar.xz
linux-55359021b9a75a6d61a49ca8b9a1209793cd55f7.zip
USB: fix signedness issue in drivers/usb/gadget/ether.c
another gcc 4.1 signdness warning: drivers/usb/gadget/ether.c:2028: warning: comparison of unsigned expression < 0 is always false length is assigned the value of usb_ep_queue() which returns an int. Directly after this it is checked for < 0, which can never be true. Making length an int makes the error check work again. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Acked-by: David Brownell <david-b@pacbell.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/gadget/ether.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
index fed484da593c..1cc3c0227d10 100644
--- a/drivers/usb/gadget/ether.c
+++ b/drivers/usb/gadget/ether.c
@@ -2014,7 +2014,7 @@ rndis_control_ack_complete (struct usb_ep *ep, struct usb_request *req)
static int rndis_control_ack (struct net_device *net)
{
struct eth_dev *dev = netdev_priv(net);
- u32 length;
+ int length;
struct usb_request *resp = dev->stat_req;
/* in case RNDIS calls this after disconnect */