diff options
| author | Maxime Ripard <maxime@cerno.tech> | 2022-07-11 19:38:57 +0200 |
|---|---|---|
| committer | Maxime Ripard <maxime@cerno.tech> | 2022-07-13 10:46:08 +0200 |
| commit | 5801eda938f5f98cbdb6bc83e2c35499735f006a (patch) | |
| tree | 6d940f45551ebc2c055d9a30e305a56ea124847e | |
| parent | drm/vc4: dpi: Return an error if we can't enable our clock (diff) | |
| download | linux-5801eda938f5f98cbdb6bc83e2c35499735f006a.tar.xz linux-5801eda938f5f98cbdb6bc83e2c35499735f006a.zip | |
drm/vc4: dpi: Remove unnecessary drm_of_panel_bridge_remove call
Since we have a managed call to create our panel_bridge instance, the call
to drm_of_panel_bridge_remove() at unbind is both redundant and dangerous
since it might lead to a use-after-free.
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220711173939.1132294-28-maxime@cerno.tech
| -rw-r--r-- | drivers/gpu/drm/vc4/vc4_dpi.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index 7028a789919d..f18b05cee8bc 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -329,8 +329,6 @@ static void vc4_dpi_unbind(struct device *dev, struct device *master, { struct vc4_dpi *dpi = dev_get_drvdata(dev); - drm_of_panel_bridge_remove(dev->of_node, 0, 0); - drm_encoder_cleanup(&dpi->encoder.base); clk_disable_unprepare(dpi->core_clock); |