diff options
author | Yi Liu <yi.l.liu@intel.com> | 2023-04-21 07:36:11 +0200 |
---|---|---|
committer | Alex Williamson <alex.williamson@redhat.com> | 2023-04-21 21:48:44 +0200 |
commit | 705b004ee377b789e39ae237519bab714297ac83 (patch) | |
tree | d7df1c36cf3acf12258fffab7cc2dbb685b3a92f | |
parent | vfio: correct kdoc for ops structures (diff) | |
download | linux-705b004ee377b789e39ae237519bab714297ac83.tar.xz linux-705b004ee377b789e39ae237519bab714297ac83.zip |
docs: kvm: vfio: Suggest KVM_DEV_VFIO_GROUP_ADD vs VFIO_GROUP_GET_DEVICE_FD ordering
as some vfio_device's open_device op requires kvm pointer and kvm pointer
set is part of GROUP_ADD.
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20230421053611.55839-1-yi.l.liu@intel.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
-rw-r--r-- | Documentation/virt/kvm/devices/vfio.rst | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/Documentation/virt/kvm/devices/vfio.rst b/Documentation/virt/kvm/devices/vfio.rst index 2d20dc561069..08b544212638 100644 --- a/Documentation/virt/kvm/devices/vfio.rst +++ b/Documentation/virt/kvm/devices/vfio.rst @@ -39,3 +39,8 @@ KVM_DEV_VFIO_GROUP attributes: - @groupfd is a file descriptor for a VFIO group; - @tablefd is a file descriptor for a TCE table allocated via KVM_CREATE_SPAPR_TCE. + +The GROUP_ADD operation above should be invoked prior to accessing the +device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to support +drivers which require a kvm pointer to be set in their .open_device() +callback. |