diff options
| author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2007-10-17 08:30:22 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 17:43:01 +0200 |
| commit | a9c62a18a291499d15a370d08771e781fbaf91e6 (patch) | |
| tree | 5d608ba9dfefce643060c1d9ab18d9f4bff18360 | |
| parent | Compile handle_percpu_irq even for uniprocessor kernels (diff) | |
| download | linux-a9c62a18a291499d15a370d08771e781fbaf91e6.tar.xz linux-a9c62a18a291499d15a370d08771e781fbaf91e6.zip | |
fs: correct SuS compliance for open of large file without options
The early LFS work that Linux uses favours EFBIG in various places. SuSv3
specifically uses EOVERFLOW for this as noted by Michael (Bug 7253)
[EOVERFLOW]
The named file is a regular file and the size of the file cannot be
represented correctly in an object of type off_t. We should therefore
transition to the proper error return code
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Theodore Tso <tytso@mit.edu>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Arjan van de Ven <arjan@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/gfs2/ops_file.c | 2 | ||||
| -rw-r--r-- | fs/ntfs/file.c | 2 | ||||
| -rw-r--r-- | fs/open.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/fs/gfs2/ops_file.c b/fs/gfs2/ops_file.c index 7eb4b280ac66..bb11fd6752d3 100644 --- a/fs/gfs2/ops_file.c +++ b/fs/gfs2/ops_file.c @@ -406,7 +406,7 @@ static int gfs2_open(struct inode *inode, struct file *file) if (!(file->f_flags & O_LARGEFILE) && ip->i_di.di_size > MAX_NON_LFS) { - error = -EFBIG; + error = -EOVERFLOW; goto fail_gunlock; } diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index c814204d4ea0..6cd08dfdc2ed 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c @@ -61,7 +61,7 @@ static int ntfs_file_open(struct inode *vi, struct file *filp) { if (sizeof(unsigned long) < 8) { if (i_size_read(vi) > MAX_LFS_FILESIZE) - return -EFBIG; + return -EOVERFLOW; } return generic_file_open(vi, filp); } diff --git a/fs/open.c b/fs/open.c index 044bfa891c94..cdbb94a9efc2 100644 --- a/fs/open.c +++ b/fs/open.c @@ -1177,7 +1177,7 @@ asmlinkage long sys_vhangup(void) int generic_file_open(struct inode * inode, struct file * filp) { if (!(filp->f_flags & O_LARGEFILE) && i_size_read(inode) > MAX_NON_LFS) - return -EFBIG; + return -EOVERFLOW; return 0; } |