diff options
| author | Jiri Pirko <jpirko@redhat.com> | 2009-05-08 15:30:17 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-05-09 22:15:48 +0200 |
| commit | ab9c73ccb52f40576ce017528d542eda3c6ae766 (patch) | |
| tree | 23ec53ffc6b55ecb9d06ee605887f5f53b73835e | |
| parent | decnet: Use data ready call back, rather than hand coding it (diff) | |
| download | linux-ab9c73ccb52f40576ce017528d542eda3c6ae766.tar.xz linux-ab9c73ccb52f40576ce017528d542eda3c6ae766.zip | |
net: check retval of dev_addr_init()
Add missed checking of dev_addr_init return value in alloc_netdev_mq.
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
net/core/dev.c | 15 ++++++++++++---
1 files changed, 12 insertions(+), 3 deletions(-)
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/dev.c | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 637ea71b0a0d..14dd725aaab7 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5007,13 +5007,16 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name, if (!tx) { printk(KERN_ERR "alloc_netdev: Unable to allocate " "tx qdiscs.\n"); - kfree(p); - return NULL; + goto free_p; } dev = (struct net_device *) (((long)p + NETDEV_ALIGN_CONST) & ~NETDEV_ALIGN_CONST); dev->padded = (char *)dev - (char *)p; + + if (dev_addr_init(dev)) + goto free_tx; + dev_net_set(dev, &init_net); dev->_tx = tx; @@ -5022,13 +5025,19 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name, dev->gso_max_size = GSO_MAX_SIZE; - dev_addr_init(dev); netdev_init_queues(dev); INIT_LIST_HEAD(&dev->napi_list); setup(dev); strcpy(dev->name, name); return dev; + +free_tx: + kfree(tx); + +free_p: + kfree(p); + return NULL; } EXPORT_SYMBOL(alloc_netdev_mq); |