summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Morton <akpm@osdl.org>2006-08-15 08:11:09 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2006-09-01 03:04:30 +0200
commiteff674a514bd3f59e0cae9b843e0665b576a5ed8 (patch)
tree624efc633bf91bcb42e55b86f935996812e72eed
parentUSB Storage: unusual_devs.h for Sony Ericsson M600i (diff)
downloadlinux-eff674a514bd3f59e0cae9b843e0665b576a5ed8.tar.xz
linux-eff674a514bd3f59e0cae9b843e0665b576a5ed8.zip
USB: rtl8150_disconnect() needs tasklet_kill()
We need to wait until any currently-running handler has completed. Fixes an unplug-time oops reported by "Miles Lane" <miles.lane@gmail.com>. Cc: "Petko Manolov" <petkan@users.sourceforge.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/net/rtl8150.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/net/rtl8150.c b/drivers/usb/net/rtl8150.c
index bd09232ce13c..a72685b96061 100644
--- a/drivers/usb/net/rtl8150.c
+++ b/drivers/usb/net/rtl8150.c
@@ -972,6 +972,7 @@ static void rtl8150_disconnect(struct usb_interface *intf)
if (dev) {
set_bit(RTL8150_UNPLUG, &dev->flags);
tasklet_disable(&dev->tl);
+ tasklet_kill(&dev->tl);
unregister_netdev(dev->netdev);
unlink_all_urbs(dev);
free_all_urbs(dev);