summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMasahiro Yamada <yamada.masahiro@socionext.com>2018-01-11 14:39:40 +0100
committerMasahiro Yamada <yamada.masahiro@socionext.com>2018-01-21 16:49:30 +0100
commit5a3dc717b3c785242e6d40f08288947cb6751ee4 (patch)
tree764bad98a5d88c257b2cef77f1bd29751c1a852e
parentkconfig: make input_mode static (diff)
downloadlinux-5a3dc717b3c785242e6d40f08288947cb6751ee4.tar.xz
linux-5a3dc717b3c785242e6d40f08288947cb6751ee4.zip
kconfig: make xfgets() really static
Sparse reports: warning: symbol 'xfgets' was not declared. Should it be static? It is declared as static, but it is missing in the definition part. Move the definition up and remove the forward declaration. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
-rw-r--r--scripts/kconfig/conf.c17
1 files changed, 7 insertions, 10 deletions
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 26156cb38ba0..a8a97efd3dfc 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -20,7 +20,6 @@
static void conf(struct menu *menu);
static void check_conf(struct menu *menu);
-static void xfgets(char *str, int size, FILE *in);
enum input_mode {
oldaskconfig,
@@ -83,6 +82,13 @@ static void check_stdin(void)
}
}
+/* Helper function to facilitate fgets() by Jean Sacren. */
+static void xfgets(char *str, int size, FILE *in)
+{
+ if (!fgets(str, size, in))
+ fprintf(stderr, "\nError in reading or end of file.\n");
+}
+
static int conf_askvalue(struct symbol *sym, const char *def)
{
enum symbol_type type = sym_get_type(sym);
@@ -713,12 +719,3 @@ int main(int ac, char **av)
}
return 0;
}
-
-/*
- * Helper function to facilitate fgets() by Jean Sacren.
- */
-void xfgets(char *str, int size, FILE *in)
-{
- if (fgets(str, size, in) == NULL)
- fprintf(stderr, "\nError in reading or end of file.\n");
-}