diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-08-04 12:16:45 +0200 |
|---|---|---|
| committer | Song Liu <songliubraving@fb.com> | 2020-08-06 02:07:48 +0200 |
| commit | e8abe1de43dac658dacbd04a4543e0c988a8d386 (patch) | |
| tree | 8a04e1f65a11776c31c4168027ace095a8bf48b4 | |
| parent | md: get sysfs entry after redundancy attr group create (diff) | |
| download | linux-e8abe1de43dac658dacbd04a4543e0c988a8d386.tar.xz linux-e8abe1de43dac658dacbd04a4543e0c988a8d386.zip | |
md-cluster: Fix potential error pointer dereference in resize_bitmaps()
The error handling calls md_bitmap_free(bitmap) which checks for NULL
but will Oops if we pass an error pointer. Let's set "bitmap" to NULL
on this error path.
Fixes: afd756286083 ("md-cluster/raid10: resize all the bitmaps before start reshape")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
| -rw-r--r-- | drivers/md/md-cluster.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c index 73fd50e77975..d50737ec4039 100644 --- a/drivers/md/md-cluster.c +++ b/drivers/md/md-cluster.c @@ -1139,6 +1139,7 @@ static int resize_bitmaps(struct mddev *mddev, sector_t newsize, sector_t oldsiz bitmap = get_bitmap_from_slot(mddev, i); if (IS_ERR(bitmap)) { pr_err("can't get bitmap from slot %d\n", i); + bitmap = NULL; goto out; } counts = &bitmap->counts; |