summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2016-04-11 09:14:46 +0200
committerJoerg Roedel <jroedel@suse.de>2016-04-15 12:09:10 +0200
commit2d8e1f039de842701d35a857a7c5d9d47bc1c639 (patch)
tree52b637e80c6688f5328bb4f73cf5afdce59a2ce2
parentiommu/amd: Set AMD iommu callbacks for amba bus (diff)
downloadlinux-2d8e1f039de842701d35a857a7c5d9d47bc1c639.tar.xz
linux-2d8e1f039de842701d35a857a7c5d9d47bc1c639.zip
iommu/amd: Signedness bug in acpihid_device_group()
"devid" needs to be signed for the error handling to work. Fixes: b097d11a0fa3f ('iommu/amd: Manage iommu_group for ACPI HID devices') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
-rw-r--r--drivers/iommu/amd_iommu.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index c430c10fb645..12f77798a0a4 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -283,7 +283,7 @@ static struct iommu_dev_data *get_dev_data(struct device *dev)
static struct iommu_group *acpihid_device_group(struct device *dev)
{
struct acpihid_map_entry *p, *entry = NULL;
- u16 devid;
+ int devid;
devid = get_acpihid_device_id(dev, &entry);
if (devid < 0)