diff options
| author | Patrick McHardy <kaber@trash.net> | 2006-03-13 05:40:43 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2006-03-13 05:40:43 +0100 |
| commit | 31fe4d331729e9687db84521c3ceb8e43390efcf (patch) | |
| tree | 3db1ef1a3daaf10d01ab18dbcc0f107857919eac | |
| parent | [IPV4/6]: Fix UFO error propagation (diff) | |
| download | linux-31fe4d331729e9687db84521c3ceb8e43390efcf.tar.xz linux-31fe4d331729e9687db84521c3ceb8e43390efcf.zip | |
[NETFILTER]: arp_tables: fix NULL pointer dereference
The check is wrong and lets NULL-ptrs slip through since !IS_ERR(NULL)
is true.
Coverity #190
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/netfilter/arp_tables.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c index dd1048be8a01..7d7ab94a7a2e 100644 --- a/net/ipv4/netfilter/arp_tables.c +++ b/net/ipv4/netfilter/arp_tables.c @@ -771,7 +771,7 @@ static int get_entries(const struct arpt_get_entries *entries, struct arpt_table *t; t = xt_find_table_lock(NF_ARP, entries->name); - if (t || !IS_ERR(t)) { + if (t && !IS_ERR(t)) { struct xt_table_info *private = t->private; duprintf("t->private->number = %u\n", private->number); |