diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2018-04-03 07:15:46 +0200 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2018-04-16 05:49:27 +0200 |
commit | 4a3877c4cedd95543f8726b0a98743ed8db0c0fb (patch) | |
tree | a10638b5471367973bc2ca40c8ce6d1bab126606 | |
parent | orangefs_kill_sb(): deal with allocation failures (diff) | |
download | linux-4a3877c4cedd95543f8726b0a98743ed8db0c0fb.tar.xz linux-4a3877c4cedd95543f8726b0a98743ed8db0c0fb.zip |
rpc_pipefs: fix double-dput()
if we ever hit rpc_gssd_dummy_depopulate() dentry passed to
it has refcount equal to 1. __rpc_rmpipe() drops it and
dput() done after that hits an already freed dentry.
Cc: stable@kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r-- | net/sunrpc/rpc_pipe.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c index 0f08934b2cea..c81ef5e6c981 100644 --- a/net/sunrpc/rpc_pipe.c +++ b/net/sunrpc/rpc_pipe.c @@ -1375,6 +1375,7 @@ rpc_gssd_dummy_depopulate(struct dentry *pipe_dentry) struct dentry *clnt_dir = pipe_dentry->d_parent; struct dentry *gssd_dir = clnt_dir->d_parent; + dget(pipe_dentry); __rpc_rmpipe(d_inode(clnt_dir), pipe_dentry); __rpc_depopulate(clnt_dir, gssd_dummy_info_file, 0, 1); __rpc_depopulate(gssd_dir, gssd_dummy_clnt_dir, 0, 1); |