summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLiu Ying <victor.liu@nxp.com>2024-08-26 10:33:37 +0200
committerUwe Kleine-König <ukleinek@kernel.org>2024-09-16 15:24:58 +0200
commit59921a7397074e90030659bbb74aad372effdeee (patch)
treec50839a59ab15d656fc21d38808b7e695ae6ed7a
parentMerge tag 'ib-mfd-gpio-pwm-v6.12' of https://git.kernel.org/pub/scm/linux/ker... (diff)
downloadlinux-59921a7397074e90030659bbb74aad372effdeee.tar.xz
linux-59921a7397074e90030659bbb74aad372effdeee.zip
pwm: adp5585: Set OSC_EN bit to 1 when PWM state is enabled
It turns out that OSC_EN bit in GERNERAL_CFG register has to be set to 1 when PWM state is enabled, otherwise PWM signal won't be generated. Fixes: e9b503879fd2 ("pwm: adp5585: Add Analog Devices ADP5585 support") Signed-off-by: Liu Ying <victor.liu@nxp.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Link: https://lore.kernel.org/r/20240826083337.1835405-1-victor.liu@nxp.com Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
-rw-r--r--drivers/pwm/pwm-adp5585.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/pwm/pwm-adp5585.c b/drivers/pwm/pwm-adp5585.c
index ed7e8c6bcf32..40472ac5db64 100644
--- a/drivers/pwm/pwm-adp5585.c
+++ b/drivers/pwm/pwm-adp5585.c
@@ -100,6 +100,10 @@ static int pwm_adp5585_apply(struct pwm_chip *chip,
if (ret)
return ret;
+ ret = regmap_set_bits(regmap, ADP5585_GENERAL_CFG, ADP5585_OSC_EN);
+ if (ret)
+ return ret;
+
return regmap_set_bits(regmap, ADP5585_PWM_CFG, ADP5585_PWM_EN);
}