diff options
author | Mark Brown <broonie@kernel.org> | 2022-08-29 18:06:56 +0200 |
---|---|---|
committer | Catalin Marinas <catalin.marinas@arm.com> | 2022-09-07 15:25:46 +0200 |
commit | 5c152c2f66f9368394b89ac90dc7483476ef7b88 (patch) | |
tree | 61daf012006a5ce0d9e2a414979ad1b720bebf47 | |
parent | kselftest/arm64: Validate signal ucontext in place (diff) | |
download | linux-5c152c2f66f9368394b89ac90dc7483476ef7b88.tar.xz linux-5c152c2f66f9368394b89ac90dc7483476ef7b88.zip |
kselftest/arm64: Fix validatation termination record after EXTRA_CONTEXT
When arm64 signal context data overflows the base struct sigcontext it gets
placed in an extra buffer pointed to by a record of type EXTRA_CONTEXT in
the base struct sigcontext which is required to be the last record in the
base struct sigframe. The current validation code attempts to check this
by using GET_RESV_NEXT_HEAD() to step forward from the current record to
the next but that is a macro which assumes it is being provided with a
struct _aarch64_ctx and uses the size there to skip forward to the next
record. Instead validate_extra_context() passes it a struct extra_context
which has a separate size field. This compiles but results in us trying
to validate a termination record in completely the wrong place, at best
failing validation and at worst just segfaulting. Fix this by passing
the struct _aarch64_ctx we meant to into the macro.
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20220829160703.874492-4-broonie@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
-rw-r--r-- | tools/testing/selftests/arm64/signal/testcases/testcases.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/arm64/signal/testcases/testcases.c b/tools/testing/selftests/arm64/signal/testcases/testcases.c index 84c36bee4d82..d98828cb542b 100644 --- a/tools/testing/selftests/arm64/signal/testcases/testcases.c +++ b/tools/testing/selftests/arm64/signal/testcases/testcases.c @@ -33,7 +33,7 @@ bool validate_extra_context(struct extra_context *extra, char **err) return false; fprintf(stderr, "Validating EXTRA...\n"); - term = GET_RESV_NEXT_HEAD(extra); + term = GET_RESV_NEXT_HEAD(&extra->head); if (!term || term->magic || term->size) { *err = "Missing terminator after EXTRA context"; return false; |