summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeert Uytterhoeven <geert@linux-m68k.org>2023-09-13 16:08:16 +0200
committerGeert Uytterhoeven <geert@linux-m68k.org>2023-10-06 10:03:02 +0200
commit676ca3c3fd9a8e341f9749fa3fecb82e1862a666 (patch)
tree739f6f15d3fd88b1189d5da14eb0d25caf9a6122
parentm68k: apollo: Replace set but not used variable by READ_ONCE() (diff)
downloadlinux-676ca3c3fd9a8e341f9749fa3fecb82e1862a666.tar.xz
linux-676ca3c3fd9a8e341f9749fa3fecb82e1862a666.zip
m68k: apollo: Add and use "apollo.h"
When building with W=1: arch/m68k/apollo/dn_ints.c:43:13: warning: no previous prototype for ‘dn_init_IRQ’ [-Wmissing-prototypes] 43 | void __init dn_init_IRQ(void) | ^~~~~~~~~~~ Fix this by introducing a new header file "apollo.h" for holding the prototypes of functions implemented in arch/m68k/apollo/. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/d78eceb83b8dd1931be1789204898060664e23f6.1694613528.git.geert@linux-m68k.org
-rw-r--r--arch/m68k/apollo/apollo.h4
-rw-r--r--arch/m68k/apollo/config.c3
-rw-r--r--arch/m68k/apollo/dn_ints.c2
3 files changed, 8 insertions, 1 deletions
diff --git a/arch/m68k/apollo/apollo.h b/arch/m68k/apollo/apollo.h
new file mode 100644
index 000000000000..1fe9d856df30
--- /dev/null
+++ b/arch/m68k/apollo/apollo.h
@@ -0,0 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+/* dn_ints.c */
+void dn_init_IRQ(void);
diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c
index 7afefb019150..e161ecd76035 100644
--- a/arch/m68k/apollo/config.c
+++ b/arch/m68k/apollo/config.c
@@ -17,6 +17,8 @@
#include <asm/machdep.h>
#include <asm/config.h>
+#include "apollo.h"
+
u_long sio01_physaddr;
u_long sio23_physaddr;
u_long rtc_physaddr;
@@ -27,7 +29,6 @@ u_long timer_physaddr;
u_long apollo_model;
extern void dn_sched_init(void);
-extern void dn_init_IRQ(void);
extern int dn_dummy_hwclk(int, struct rtc_time *);
static void dn_dummy_reset(void);
#ifdef CONFIG_HEARTBEAT
diff --git a/arch/m68k/apollo/dn_ints.c b/arch/m68k/apollo/dn_ints.c
index d97251fe0ab8..ba96a92f8f18 100644
--- a/arch/m68k/apollo/dn_ints.c
+++ b/arch/m68k/apollo/dn_ints.c
@@ -5,6 +5,8 @@
#include <asm/traps.h>
#include <asm/apollohw.h>
+#include "apollo.h"
+
static unsigned int apollo_irq_startup(struct irq_data *data)
{
unsigned int irq = data->irq;