diff options
| author | Joseph Qi <joseph.qi@linux.alibaba.com> | 2020-11-03 03:29:02 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2020-11-07 04:52:36 +0100 |
| commit | 7067b2619017d51e71686ca9756b454de0e5826a (patch) | |
| tree | ba8c392b3aa53be864c35aa9934699aafe6e0b44 | |
| parent | ext4: silence an uninitialized variable warning (diff) | |
| download | linux-7067b2619017d51e71686ca9756b454de0e5826a.tar.xz linux-7067b2619017d51e71686ca9756b454de0e5826a.zip | |
ext4: unlock xattr_sem properly in ext4_inline_data_truncate()
It takes xattr_sem to check inline data again but without unlock it
in case not have. So unlock it before return.
Fixes: aef1c8513c1f ("ext4: let ext4_truncate handle inline data correctly")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/1604370542-124630-1-git-send-email-joseph.qi@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
| -rw-r--r-- | fs/ext4/inline.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index caa51473207d..b41512d1badc 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -1880,6 +1880,7 @@ int ext4_inline_data_truncate(struct inode *inode, int *has_inline) ext4_write_lock_xattr(inode, &no_expand); if (!ext4_has_inline_data(inode)) { + ext4_write_unlock_xattr(inode, &no_expand); *has_inline = 0; ext4_journal_stop(handle); return 0; |