summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRasmus Villemoes <linux@rasmusvillemoes.dk>2019-11-28 15:55:47 +0100
committerLi Yang <leoyang.li@nxp.com>2019-12-09 20:54:36 +0100
commit71352b8c4016fbf24e5244877c2ebf93eb9d4c73 (patch)
tree26814bc3eaf1fe6b004834ee44e948a22381a091
parentsoc: fsl: qe: drop use of IS_ERR_VALUE in qe_sdma_init() (diff)
downloadlinux-71352b8c4016fbf24e5244877c2ebf93eb9d4c73.tar.xz
linux-71352b8c4016fbf24e5244877c2ebf93eb9d4c73.zip
soc: fsl: qe: drop pointless check in qe_sdma_init()
The sdma member of struct qe_immap is not at offset zero, so even if qe_immr wasn't initialized yet (i.e. NULL), &qe_immr->sdma would not be NULL. Reviewed-by: Timur Tabi <timur@kernel.org> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by: Li Yang <leoyang.li@nxp.com>
-rw-r--r--drivers/soc/fsl/qe/qe.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
index 5bf279c679ef..96c2057d8d8e 100644
--- a/drivers/soc/fsl/qe/qe.c
+++ b/drivers/soc/fsl/qe/qe.c
@@ -367,9 +367,6 @@ static int qe_sdma_init(void)
struct sdma __iomem *sdma = &qe_immr->sdma;
static s32 sdma_buf_offset = -ENOMEM;
- if (!sdma)
- return -ENODEV;
-
/* allocate 2 internal temporary buffers (512 bytes size each) for
* the SDMA */
if (sdma_buf_offset < 0) {