diff options
| author | Roland Dreier <rolandd@cisco.com> | 2008-04-17 06:09:25 +0200 |
|---|---|---|
| committer | Roland Dreier <rolandd@cisco.com> | 2008-04-17 06:09:25 +0200 |
| commit | 782203884eea5f610444bcf4ed1b4af0010911eb (patch) | |
| tree | 0fa59c5ee52e0de3666b65953db2bd00623205e8 | |
| parent | IB/ipath: Fix sanity checks on QP number of WRs and SGEs (diff) | |
| download | linux-782203884eea5f610444bcf4ed1b4af0010911eb.tar.xz linux-782203884eea5f610444bcf4ed1b4af0010911eb.zip | |
IB/ipath: Fix PCI config write size used to clear linkctrl error bits
In slave_or_pri_blk(), pci_write_config_byte() is used to write a
16-bit quantity to clear linkctrl CRC error bits. This is clearly a
bug and also causes the warning
drivers/infiniband/hw/ipath/ipath_iba6110.c: In function 'slave_or_pri_blk':
drivers/infiniband/hw/ipath/ipath_iba6110.c:849: warning: overflow in implicit constant conversion
Fix this by using pci_write_config_word() instead.
Acked-by: Ralph Campbell <ralph.campbell@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
| -rw-r--r-- | drivers/infiniband/hw/ipath/ipath_iba6110.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/ipath/ipath_iba6110.c b/drivers/infiniband/hw/ipath/ipath_iba6110.c index 19e3955304c0..d241f1c7c93e 100644 --- a/drivers/infiniband/hw/ipath/ipath_iba6110.c +++ b/drivers/infiniband/hw/ipath/ipath_iba6110.c @@ -845,7 +845,7 @@ static void slave_or_pri_blk(struct ipath_devdata *dd, struct pci_dev *pdev, /* * now write them back to clear the error. */ - pci_write_config_byte(pdev, link_off, + pci_write_config_word(pdev, link_off, linkctrl & (0xf << 8)); } } |