diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2024-04-10 16:05:49 +0200 |
|---|---|---|
| committer | Ulf Hansson <ulf.hansson@linaro.org> | 2024-04-25 11:58:52 +0200 |
| commit | 8401659fab6f437f1291b1ab37905d284b07b2f9 (patch) | |
| tree | b49a78caf786bd8f8f7dd37c1fde70227a711893 | |
| parent | memstick: rtsx_pci_ms: Drop if block with always false condition (diff) | |
| download | linux-8401659fab6f437f1291b1ab37905d284b07b2f9.tar.xz linux-8401659fab6f437f1291b1ab37905d284b07b2f9.zip | |
memstick: rtsx_pci_ms: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/512d6b6a4d3b8a02cee28635a936340f5f70c65e.1712757795.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
| -rw-r--r-- | drivers/memstick/host/rtsx_pci_ms.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/memstick/host/rtsx_pci_ms.c b/drivers/memstick/host/rtsx_pci_ms.c index 7c6dba6de230..980a54513e6c 100644 --- a/drivers/memstick/host/rtsx_pci_ms.c +++ b/drivers/memstick/host/rtsx_pci_ms.c @@ -574,7 +574,7 @@ static int rtsx_pci_ms_drv_probe(struct platform_device *pdev) return 0; } -static int rtsx_pci_ms_drv_remove(struct platform_device *pdev) +static void rtsx_pci_ms_drv_remove(struct platform_device *pdev) { struct realtek_pci_ms *host = platform_get_drvdata(pdev); struct rtsx_pcr *pcr; @@ -610,8 +610,6 @@ static int rtsx_pci_ms_drv_remove(struct platform_device *pdev) dev_dbg(&(pdev->dev), ": Realtek PCI-E Memstick controller has been removed\n"); - - return 0; } static struct platform_device_id rtsx_pci_ms_ids[] = { @@ -625,7 +623,7 @@ MODULE_DEVICE_TABLE(platform, rtsx_pci_ms_ids); static struct platform_driver rtsx_pci_ms_driver = { .probe = rtsx_pci_ms_drv_probe, - .remove = rtsx_pci_ms_drv_remove, + .remove_new = rtsx_pci_ms_drv_remove, .id_table = rtsx_pci_ms_ids, .suspend = rtsx_pci_ms_suspend, .resume = rtsx_pci_ms_resume, |