summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLi Huafei <lihuafei1@huawei.com>2024-10-31 12:27:55 +0100
committerHerbert Xu <herbert@gondor.apana.org.au>2024-11-10 04:50:54 +0100
commita10549fcce2913be7dc581562ffd8ea35653853e (patch)
tree2ec415058a2e32c8a686ee7e46c9c6cb55ceb638
parentcrypto: qat - Fix missing destroy_workqueue in adf_init_aer() (diff)
downloadlinux-a10549fcce2913be7dc581562ffd8ea35653853e.tar.xz
linux-a10549fcce2913be7dc581562ffd8ea35653853e.zip
crypto: inside-secure - Fix the return value of safexcel_xcbcmac_cra_init()
The commit 320406cb60b6 ("crypto: inside-secure - Replace generic aes with libaes") replaced crypto_alloc_cipher() with kmalloc(), but did not modify the handling of the return value. When kmalloc() returns NULL, PTR_ERR_OR_ZERO(NULL) returns 0, but in fact, the memory allocation has failed, and -ENOMEM should be returned. Fixes: 320406cb60b6 ("crypto: inside-secure - Replace generic aes with libaes") Signed-off-by: Li Huafei <lihuafei1@huawei.com> Acked-by: Antoine Tenart <atenart@kernel.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--drivers/crypto/inside-secure/safexcel_hash.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/inside-secure/safexcel_hash.c b/drivers/crypto/inside-secure/safexcel_hash.c
index e17577b785c3..f44c08f5f5ec 100644
--- a/drivers/crypto/inside-secure/safexcel_hash.c
+++ b/drivers/crypto/inside-secure/safexcel_hash.c
@@ -2093,7 +2093,7 @@ static int safexcel_xcbcmac_cra_init(struct crypto_tfm *tfm)
safexcel_ahash_cra_init(tfm);
ctx->aes = kmalloc(sizeof(*ctx->aes), GFP_KERNEL);
- return PTR_ERR_OR_ZERO(ctx->aes);
+ return ctx->aes == NULL ? -ENOMEM : 0;
}
static void safexcel_xcbcmac_cra_exit(struct crypto_tfm *tfm)