summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhang Zekun <zhangzekun11@huawei.com>2024-10-24 05:04:41 +0200
committerUlf Hansson <ulf.hansson@linaro.org>2024-10-31 11:30:57 +0100
commitafc2331ef81657493c074592c409dac7c3cb8ccc (patch)
tree50799e7798ed47ababb1eadb0a690b24c5b1be1a
parentpmdomain: Merge branch fixes into next (diff)
downloadlinux-afc2331ef81657493c074592c409dac7c3cb8ccc.tar.xz
linux-afc2331ef81657493c074592c409dac7c3cb8ccc.zip
pmdomain: ti-sci: Add missing of_node_put() for args.np
of_parse_phandle_with_args() needs to call of_node_put() to decrement the refcount of args.np. So, Add the missing of_node_put() in the loop. Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one") Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> Reviewed-by: Dhruva Gole <d-gole@ti.com> Message-ID: <20241024030442.119506-2-zhangzekun11@huawei.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
-rw-r--r--drivers/pmdomain/ti/ti_sci_pm_domains.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c
index 38448b4a035a..f145f0225524 100644
--- a/drivers/pmdomain/ti/ti_sci_pm_domains.c
+++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c
@@ -161,6 +161,7 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev)
break;
if (args.args_count >= 1 && args.np == dev->of_node) {
+ of_node_put(args.np);
if (args.args[0] > max_id) {
max_id = args.args[0];
} else {
@@ -193,7 +194,10 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev)
pm_genpd_init(&pd->pd, NULL, true);
list_add(&pd->node, &pd_provider->pd_list);
+ } else {
+ of_node_put(args.np);
}
+
index++;
}
}