diff options
| author | Johan Hovold <johan@kernel.org> | 2017-10-11 14:03:00 +0200 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2017-10-11 15:24:55 +0200 |
| commit | c1a357b68614620c976a94260749a979f9c46d29 (patch) | |
| tree | dc1ad327a3df27f3c997c475395cb6f167493bdc | |
| parent | USB: serial: garmin_gps: drop unused timer initialisation (diff) | |
| download | linux-c1a357b68614620c976a94260749a979f9c46d29.tar.xz linux-c1a357b68614620c976a94260749a979f9c46d29.zip | |
USB: serial: garmin_gps: clean up init-session messages
Use the port device for any init-session error and debug messages,
remove one redundant debug message and simplify one error message.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
| -rw-r--r-- | drivers/usb/serial/garmin_gps.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c index d22a84c95c07..5f7832adf6af 100644 --- a/drivers/usb/serial/garmin_gps.c +++ b/drivers/usb/serial/garmin_gps.c @@ -876,7 +876,6 @@ static int garmin_clear(struct garmin_data *garmin_data_p) static int garmin_init_session(struct usb_serial_port *port) { - struct usb_serial *serial = port->serial; struct garmin_data *garmin_data_p = usb_get_serial_port_data(port); int status = 0; int i = 0; @@ -884,12 +883,12 @@ static int garmin_init_session(struct usb_serial_port *port) if (status == 0) { usb_kill_urb(port->interrupt_in_urb); - dev_dbg(&serial->dev->dev, "%s - adding interrupt input\n", __func__); status = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); - if (status) - dev_err(&serial->dev->dev, - "%s - failed submitting interrupt urb, error %d\n", - __func__, status); + if (status) { + dev_err(&port->dev, + "failed to submit interrupt urb: %d\n", + status); + } } /* @@ -897,7 +896,7 @@ static int garmin_init_session(struct usb_serial_port *port) * gpsbabel/jeeps/gpslibusb.c gusb_reset_toggles() */ if (status == 0) { - dev_dbg(&serial->dev->dev, "%s - starting session ...\n", __func__); + dev_dbg(&port->dev, "%s - starting session ...\n", __func__); garmin_data_p->state = STATE_ACTIVE; for (i = 0; i < 3; i++) { |