diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-06-19 22:26:15 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-06-20 22:04:12 +0200 |
| commit | c82b9d7fe7464aec78210544948564ffe3bb2d2b (patch) | |
| tree | 7ee0b05997447d695b92f3890e47709f4f07c87c | |
| parent | sgi-xp: fix a use after free (diff) | |
| download | linux-c82b9d7fe7464aec78210544948564ffe3bb2d2b.tar.xz linux-c82b9d7fe7464aec78210544948564ffe3bb2d2b.zip | |
netxen: fix race in skb->len access
As soon as skb is given to hardware, TX completion can free skb under
us.
Therefore, we should update dev stats before kicking the device.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Amit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/netxen/netxen_nic_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index b644383017f9..c0788a31ff0f 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/drivers/net/netxen/netxen_nic_main.c @@ -1965,11 +1965,11 @@ netxen_nic_xmit_frame(struct sk_buff *skb, struct net_device *netdev) netxen_tso_check(netdev, tx_ring, first_desc, skb); - netxen_nic_update_cmd_producer(adapter, tx_ring); - adapter->stats.txbytes += skb->len; adapter->stats.xmitcalled++; + netxen_nic_update_cmd_producer(adapter, tx_ring); + return NETDEV_TX_OK; drop_packet: |