diff options
| author | Yinhao Hu <dddddd@hust.edu.cn> | 2023-04-12 07:58:52 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-04-20 11:16:42 +0200 |
| commit | d6f712f53b79f5017cdcefafb7a5aea9ec52da5d (patch) | |
| tree | b9f7108e8456223800251f10178ddb3093492ada | |
| parent | usb: gadget: udc: core: Prevent redundant calls to pullup (diff) | |
| download | linux-d6f712f53b79f5017cdcefafb7a5aea9ec52da5d.tar.xz linux-d6f712f53b79f5017cdcefafb7a5aea9ec52da5d.zip | |
usb: chipidea: fix missing goto in `ci_hdrc_probe`
From the comment of ci_usb_phy_init, it returns an error code if
usb_phy_init has failed, and it should do some clean up, not just
return directly.
Fix this by goto the error handling.
Fixes: 74475ede784d ("usb: chipidea: move PHY operation to core")
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Acked-by: Peter Chen <peter.chen@kernel.org>
Signed-off-by: Yinhao Hu <dddddd@hust.edu.cn>
Link: https://lore.kernel.org/r/20230412055852.971991-1-dddddd@hust.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/chipidea/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index d1d252c87e4f..798cb077867a 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -1108,7 +1108,7 @@ static int ci_hdrc_probe(struct platform_device *pdev) ret = ci_usb_phy_init(ci); if (ret) { dev_err(dev, "unable to init phy: %d\n", ret); - return ret; + goto ulpi_exit; } ci->hw_bank.phys = res->start; |